Adapt appendPsqlMetaConnect() to the new fmtId() encoding expectations.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 10 Feb 2025 21:30:03 +0000 (16:30 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 10 Feb 2025 21:30:37 +0000 (16:30 -0500)
commit0075a5c6ce5bb6f3ee005a54cd5b518f16659655
tree4b9e953a704da74c95ca7e14bc9fc6140575d44d
parent41343f84052eb53a900ea464a8ce16a548cab901
Adapt appendPsqlMetaConnect() to the new fmtId() encoding expectations.

We need to tell fmtId() what encoding to assume, but this function
doesn't know that.  Fortunately we can fix that without changing the
function's API, because we can just use SQL_ASCII.  That's because
database names in connection requests are effectively binary not text:
no encoding-aware processing will happen on them.

This fixes XversionUpgrade failures seen in the buildfarm.  The
alternative of having pg_upgrade use setFmtEncoding() is unappetizing,
given that it's connecting to multiple databases that may have
different encodings.

Andres Freund, Noah Misch, Tom Lane

Security: CVE-2025-1094
src/fe_utils/string_utils.c