Issue 98280044: Properly pass parameters to test executables.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 98280044: Properly pass parameters to test executables.

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by csharp

Modified:
11 years, 7 months ago

Reviewers:
M-A

CC:
swarming-eng_googlegroups.com, csharp+cc_chromium.org, vadimsh+cc_chromium.org

Base URL:
https://code.google.com/p/swarming.client/@master

Visibility:
Public.

More Reviews

Description

Properly pass parameters to test executables. Fixes crbug.com/373630

Patch Set 1 : #

Total comments: 2

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -10 lines)			Patch
	M	googletest/fix_test_cases.py	View		2 chunks	+8 lines, -10 lines	2 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

csharp

I'm not completely sure why, but in the old format (no =) the commandline class ...

11 years, 7 months ago (2014-05-15 17:44:30 UTC) #1

M-A

https://codereview.appspot.com/98280044/diff/20001/googletest/fix_test_cases.py File googletest/fix_test_cases.py (right): https://codereview.appspot.com/98280044/diff/20001/googletest/fix_test_cases.py#newcode97 googletest/fix_test_cases.py:97: # This assumes run_test_cases.py is used. The problem is ...

11 years, 7 months ago (2014-05-15 18:20:34 UTC) #2

csharp

11 years, 7 months ago (2014-05-15 18:24:25 UTC) #3

https://codereview.appspot.com/98280044/diff/20001/googletest/fix_test_cases.py
File googletest/fix_test_cases.py (right):

https://codereview.appspot.com/98280044/diff/20001/googletest/fix_test_cases....
googletest/fix_test_cases.py:97: # This assumes run_test_cases.py is used.
On 2014/05/15 18:20:34, M-A wrote:
> The problem is that run_test_cases.py is not used anymore, it's test launcher
> that is getting these. And the way it parses argument is with --foo=bar. That
> means more parameters are ignored, including --result. Test launcher can
output
> .json file about each unit test, it's just different from run_test_cases.py's
> format.
> 
> So in the meantime we may just want to delete the script and references to it.
> :/

Delete this script? I think this fixes the problems though so why not keep it?

Expand All Messages | Collapse All Messages