fediverse/fep
fediverse/fep
39
248
Fork 87
Code Issues 137 Pull requests 17 Releases Activity

[TRACKING] FEP-e232: Object Links #14

New issue
Open
opened 2022-08-05 07:35:55 +02:00 by circlebuilder · 14 comments
circlebuilder commented 2022-08-05 07:35:55 +02:00
Owner
Copy link

Proposal by @silverpill
The proposal has been received. Thank you!

This issue tracks discussions and updates to the proposal during the DRAFT period.

Please post links to relevant discussions as comment to this issue.

dateReceived: 2022-08-01

If no further actions are taken, the proposal will be automatically set to WITHDRAWN on 2022-12-01 (in 4 months).

Proposal by @silverpill The proposal has been received. Thank you! This issue tracks discussions and updates to the proposal during the `DRAFT` period. Please post links to relevant discussions as comment to this issue. `dateReceived`: 2022-08-01 If no further actions are taken, the proposal will be automatically set to `WITHDRAWN` on 2022-12-01 (in 4 months).
circlebuilder commented 2022-08-05 07:41:11 +02:00
Author
Owner
Copy link

Thank you @silverpill if the outstanding review comment on #13 is resolved we can merge the DRAFT.

After that is done, can you create a discussion on SocialHub in Fediverse Enhancement Proposals category titled "FEP-e232: Object Links", with tags fep and fep-e232, a brief introduction and a link to your draft at Codeberg?

Thank you @silverpill if the outstanding review comment on #13 is resolved we can merge the DRAFT. After that is done, can you create a discussion on SocialHub in [Fediverse Enhancement Proposals](https://socialhub.activitypub.rocks/c/standards/fep/54) category titled "FEP-e232: Object Links", with tags `fep` and `fep-e232`, a brief introduction and a link to your draft at Codeberg?
silverpill commented 2022-08-05 13:54:33 +02:00
Owner
Copy link

Relevant conversations I'm aware of:

@circlebuilder I've resolved trwnh's review. I would like to keep two remaining comments open if it's possible, as they explain certain design decisions.

After that is done, can you create a discussion on SocialHub in Fediverse Enhancement Proposals category titled "FEP-e232: Object Links", with tags fep and fep-e232, a brief introduction and a link to your draft at Codeberg?

We already have a discussion about quotes on SocialHub, should I create a new one regardless?

Relevant conversations I'm aware of: - https://socialhub.activitypub.rocks/t/repost-share-with-quote-a-k-a-attach-someone-elses-post-to-your-own-post/659 - https://github.com/misskey-dev/misskey/issues/8722 (there's an open [PR](https://github.com/misskey-dev/misskey/pull/8837) that implements quotes in a way that is compatible with this FEP) - https://git.pleroma.social/pleroma/pleroma/-/issues/2783 - https://github.com/mastodon/mastodon/issues/18473 @circlebuilder I've resolved trwnh's review. I would like to keep two remaining comments open if it's possible, as they explain certain design decisions. >After that is done, can you create a discussion on SocialHub in Fediverse Enhancement Proposals category titled "FEP-e232: Object Links", with tags fep and fep-e232, a brief introduction and a link to your draft at Codeberg? We already have a [discussion](https://socialhub.activitypub.rocks/t/repost-share-with-quote-a-k-a-attach-someone-elses-post-to-your-own-post/659) about quotes on SocialHub, should I create a new one regardless?
circlebuilder commented 2022-08-05 14:43:07 +02:00
Author
Owner
Copy link

There's no hurry on getting the draft merged. A separate SocialHub topic is part of the FEP process and can help attract attention to your document. It is also easier to find later. The forum is like an archive in that regard.

In the new topic you can make reference to the other one (where you can add a comment to fully cross-ref). Text can be short, that is up to you. But you might point out aspects that you are most in need of feedback for. Among goals of the FEP is to get exposure to the enhancement, and as much consensus and buy-in so other apps will adopt it hopefully.

There's no hurry on getting the draft merged. A separate SocialHub topic is part of the FEP process and can help attract attention to your document. It is also easier to find later. The forum is like an archive in that regard. In the new topic you can make reference to the other one (where you can add a comment to fully cross-ref). Text can be short, that is up to you. But you might point out aspects that you are most in need of feedback for. Among goals of the FEP is to get exposure to the enhancement, and as much consensus and buy-in so other apps will adopt it hopefully.
👍 2
silverpill commented 2022-08-05 22:19:52 +02:00
Owner
Copy link

Thanks, I've created the topic: https://socialhub.activitypub.rocks/t/fep-e232-object-links/2536
I can't find a way to add new tag, so for now I only added fep and draft, without fep-e232.

Thanks, I've created the topic: https://socialhub.activitypub.rocks/t/fep-e232-object-links/2536 I can't find a way to add new tag, so for now I only added `fep` and `draft`, without `fep-e232`.
👍 2
silverpill commented 2022-09-01 20:47:57 +02:00
Owner
Copy link

Is there anything else that needs to be done?

Is there anything else that needs to be done?
weex commented 2022-11-28 19:43:50 +01:00
Owner
Copy link

To match newly implemented automation the discussion topic was moved to: https://socialhub.activitypub.rocks/t/fep-e232-object-links/2722

To match newly implemented automation the discussion topic was moved to: https://socialhub.activitypub.rocks/t/fep-e232-object-links/2722
weex commented 2022-11-28 19:48:32 +01:00
Owner
Copy link

Is there anything else that needs to be done?

If you feel everything's been addressed, then in a few days it becomes eligible for FINAL.

> Is there anything else that needs to be done? If you feel everything's been addressed, then in a few days it becomes eligible for FINAL.
silverpill commented 2022-11-28 20:28:21 +01:00
Owner
Copy link

We discovered that this FEP is not backwards compatible with Pleroma.
I would prefer to not finalize it until this issue is addressed (either by patching Pleroma or by changing the FEP). I also think there should be at least two interoperable implementations before we can consider it FINAL.

We discovered that this FEP is [not backwards compatible with Pleroma](https://socialhub.activitypub.rocks/t/fep-e232-object-links/2722/12?u=silverpill). I would prefer to not finalize it until this issue is addressed (either by patching Pleroma or by changing the FEP). I also think there should be at least two interoperable implementations before we can consider it FINAL.
weex commented 2022-11-28 20:34:13 +01:00
Owner
Copy link

I also think there should be at least two interoperable implementations before we can consider it FINAL.

This would be good to discuss in a new issue.

> I also think there should be at least two interoperable implementations before we can consider it FINAL. This would be good to discuss in a new issue.
silverpill commented 2022-11-28 21:28:34 +01:00
Owner
Copy link

That's just my preference in regards to FEP-e232. I think it shouldn't be applied to all proposals, which may describe something other than a protocol extension.

That's just my preference in regards to FEP-e232. I think it shouldn't be applied to all proposals, which may describe something other than a protocol extension.
silverpill commented 2023-10-14 18:52:33 +02:00
Owner
Copy link

Proposal was updated via #173

Proposal was updated via #173
silverpill commented 2023-11-03 18:45:02 +01:00
Owner
Copy link

Another update: #203

And I'm requesting finalization of this proposal: https://socialhub.activitypub.rocks/t/fep-e232-object-links/2722/58

Another update: #203 And I'm requesting finalization of this proposal: https://socialhub.activitypub.rocks/t/fep-e232-object-links/2722/58
weex commented 2023-12-03 16:47:37 +01:00
Owner
Copy link

Looks like no final comments so created a new branch finalize-e232. Was going to edit the README.md but it says to use the create_readme.py script so leaving a note here until I can get the script going. Feel free to update the branch and create a PR if you see this and have the script handy.

Looks like no final comments so created a new branch `finalize-e232`. Was going to edit the README.md but it says to use the create_readme.py script so leaving a note here until I can get the script going. Feel free to update the branch and create a PR if you see this and have the script handy.
👀 1
helge commented 2023-12-06 19:50:19 +01:00
Owner
Copy link

Was going to edit the README.md but it says to use the create_readme.py script so leaving a note here until I can get the script going.

Can you describe your problems?

I just have to run

python scripts/create_readme.py

and README.md is updated. Maybe I should add the missing "python" in the note?

> Was going to edit the README.md but it says to use the create_readme.py script so leaving a note here until I can get the script going. Can you describe your problems? I just have to run ```bash python scripts/create_readme.py ``` and README.md is updated. Maybe I should add the missing "python" in the note?
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
pages
No results found.
Labels
Clear labels   
bug

Something is not working

  
contribution welcome

Contributions are very welcome, get started here

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
FEP Draft

Indicates a tracking issue corresponding to Draft FEP

  
FEP Final

Indicates a tracking issue corresponding to Final FEP

  
FEP Withdrawn

Indicates a tracking issue corresponding to withdrawn FEP

  
final comments

   
good first issue

Interested in contributing? Get started here.

  
help wanted

Need some help

  
invalid

Something is wrong

  
meta

   
question

More information is needed

  
syntax fix

   
upstream

Related to an upstream repository, already reported there

No labels
bug
contribution welcome
duplicate
enhancement
FEP Draft
FEP Final
FEP Withdrawn
final comments
good first issue
help wanted
invalid
meta
question
syntax fix
upstream
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
fediverse/fep#14
No description provided.