Debian Bug report logs - #853224
desktop-base: Minor problems with maintainer scripts

Display info messages

Message #5 received at submit@bugs.debian.org (full text, mbox, reply):

From: Raphaël Hertzog <hertzog@debian.org>

To: Debian Bug Tracking System <submit@bugs.debian.org>

Subject: desktop-base: Minor problems with maintainer scripts

Date: Mon, 30 Jan 2017 18:49:39 +0100

Package: desktop-base
Version: 9.0.2
Severity: normal
User: devel@kali.org
Usertags: origin-kali

I'm updating the Kali package based on 9.0.2 and I am thus reviewing the
changes. I found some problems:

* In debian/postrm:
- there are many "$priority" variables used that should be dropped as the
  update-alternatives --remove call does not need a priority
- there's a "read theme priority" that should be changed into "read theme"
- you are removing the "desktop-grub.sh" alternative but it's a slave
  alternative... aren't those automatically removed?
  And in fact, you are removing them twice... in two consecutive loops.

* In debian/preinst:
  You have code like this:
  if $2 <= 9.0.0~exp1; then
    ...
    if $2 >= 9.0.0~exp1; then
      echo "ge 9.0.0~exp1"
      ...
    fi
  fi
  if $2 < 9.0.0~; then
    ...
  fi

  First there's debugging code (the "echo" line) and what's the point of
  the embedded check >= 9.0.0~exp1 ?  The only way to trigger it is when $2 = 9.0.0~exp1
  since it must meet >= 9.0.0~exp1 and <= 9.0.0~exp1 at the same time.

  The ordering does not seem very logic. You usally deal with upgrade
  problems of older versions first. So it seems to me that you should
  do something like this:
  if $2 < 9.0.0~; then
    ...
  fi
  if $2 = 9.0.0~exp1; then
    ...
  fi

  And AFAIK you don't need any other case since 9.0.0~exp1 followed
  immediately 8.0.2.

Cheers,

-- System Information:
Debian Release: 9.0
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'stable'), (500, 'oldstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 4.9.0-1-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages desktop-base depends on:
ii  dpkg             1.18.18
ii  librsvg2-common  2.40.16-1

desktop-base recommends no packages.

Versions of packages desktop-base suggests:
ii  gnome  1:3.20+3

-- no debconf information

Message #10 received at submit@bugs.debian.org (full text, mbox, reply):

From: Aurélien COUDERC <zecoucou@free.fr>

To: Raphaël Hertzog <hertzog@debian.org>, 853224@bugs.debian.org, Debian Bug Tracking System <submit@bugs.debian.org>

Subject: Re: Bug#853224: desktop-base: Minor problems with maintainer scripts

Date: Mon, 30 Jan 2017 23:02:03 +0100

control: tags -1 pending
control: severity -1 minor

Hi Raphaël,

thanks for your in depth review.
It was obviously useful. :-)


Le 30/01/2017 à 18:49, Raphaël Hertzog a écrit :
> Package: desktop-base
> Version: 9.0.2
> Severity: normal
> User: devel@kali.org
> Usertags: origin-kali
>
> I'm updating the Kali package based on 9.0.2 and I am thus reviewing the
> changes. I found some problems:
>
> * In debian/postrm:
That’s prerm.

> - there are many "$priority" variables used that should be dropped as the
>   update-alternatives --remove call does not need a priority
Yes, fixed.

> - there's a "read theme priority" that should be changed into "read theme"
Yes, fixed.

> - you are removing the "desktop-grub.sh" alternative but it's a slave
>   alternative... aren't those automatically removed?
>   And in fact, you are removing them twice... in two consecutive loops.
Indeed, fixed.

> * In debian/preinst:
>   You have code like this:
>   if $2 <= 9.0.0~exp1; then
>     ...
>     if $2 >= 9.0.0~exp1; then
>       echo "ge 9.0.0~exp1"
>       ...
>     fi
>   fi
>   if $2 < 9.0.0~; then
>     ...
>   fi
>
>   First there's debugging code (the "echo" line)
Yes, removed.
>  and what's the point of
>   the embedded check >= 9.0.0~exp1 ?  The only way to trigger it is when $2 = 9.0.0~exp1
>   since it must meet >= 9.0.0~exp1 and <= 9.0.0~exp1 at the same time.
>
>   The ordering does not seem very logic. You usally deal with upgrade
>   problems of older versions first. So it seems to me that you should
>   do something like this:
>   if $2 < 9.0.0~; then
>     ...
>   fi
>   if $2 = 9.0.0~exp1; then
>     ...
>   fi
>
>   And AFAIK you don't need any other case since 9.0.0~exp1 followed
>   immediately 8.0.2.
Right, agreed, fixed as you proposed.

So all this is committed into SVN.
I’ve quickly tested install and upgrades from 8.0.2 and from 9.0.2, and
they worked without errors.
Feel free to re-check though :
https://anonscm.debian.org/viewvc/debian-desktop?view=revision&revision=445

It won’t make it into Stretch as the freeze it at the door, but it
should be fine. These are all more style / cleanups fixes that don’t
change the result of maintscripts execution AFAICT.
I’ve requalified severity as minor to match the bug’s title but if you
think it’s inappropriate, please revert it.


Cheers,
--Aurélien

Message #26 received at 853224@bugs.debian.org (full text, mbox, reply):

From: Yves-Alexis Perez <corsac@debian.org>

To: Holger Levsen <holger@layer-acht.org>

Cc: 853224@bugs.debian.org, Raphaël Hertzog <hertzog@debian.org>

Subject: Re: Processed: severity

Date: Tue, 14 Mar 2017 21:09:46 +0100

[Message part 1 (text/plain, inline)]

On Tue, 2017-03-14 at 12:12 +0000, Debian Bug Tracking System wrote:
> Processing commands for control@bugs.debian.org:
> 
> > severity 853224 normal
> 
> Bug #853224 [desktop-base] desktop-base: Minor problems with maintainer
> scripts
> Severity set to 'normal' from 'minor'
> > # I fail to see how this is minor…
> > --
> 
Hi, I don't want to sound too nitpicky but if you read the message from
Aurélien leading to that lowering, it's all explained:

> It won’t make it into Stretch as the freeze it at the door, but it
> should be fine. These are all more style / cleanups fixes that don’t
> change the result of maintscripts execution AFAICT.
> I’ve requalified severity as minor to match the bug’s title but if you
> think it’s inappropriate, please revert it.

My guess is that Raphaël didn't disagree and Aurélien, as member of the
maintainers team, is perfectly legitimate to set the severity.

Regards,
-- 
Yves-Alexis

[signature.asc (application/pgp-signature, inline)]

Message #31 received at 853224@bugs.debian.org (full text, mbox, reply):

From: Holger Levsen <holger@layer-acht.org>

To: Yves-Alexis Perez <corsac@debian.org>

Cc: 853224@bugs.debian.org, Raphaël Hertzog <hertzog@debian.org>

Subject: Re: Processed: severity

Date: Tue, 14 Mar 2017 20:21:31 +0000

[Message part 1 (text/plain, inline)]

On Tue, Mar 14, 2017 at 09:09:46PM +0100, Yves-Alexis Perez wrote:
> My guess is that Raphaël didn't disagree and Aurélien, as member of the
> maintainers team, is perfectly legitimate to set the severity.

I've discussed this privatly with Aurélien prio doing this…

-- 
cheers,
	Holger

[signature.asc (application/pgp-signature, inline)]

Message #36 received at 853224@bugs.debian.org (full text, mbox, reply):

From: Aurélien COUDERC <zecoucou@free.fr>

To: Holger Levsen <holger@layer-acht.org>,853224@bugs.debian.org,Yves-Alexis Perez <corsac@debian.org>

Cc: Raphaël Hertzog <hertzog@debian.org>

Subject: Re: Bug#853224: Processed: severity

Date: Tue, 14 Mar 2017 23:57:42 +0100

[Message part 1 (text/plain, inline)]

Le 14 mars 2017 21:21:31 GMT+01:00, Holger Levsen <holger@layer-acht.org> a écrit :
>On Tue, Mar 14, 2017 at 09:09:46PM +0100, Yves-Alexis Perez wrote:
>> My guess is that Raphaël didn't disagree and Aurélien, as member of
>the
>> maintainers team, is perfectly legitimate to set the severity.
>
>I've discussed this privatly with Aurélien prio doing this…
>
>-- 
>cheers,
>	Holger

Yes I'm fine with preparing a package with just this fix. It may not change the behaviour but it will be cleaner and more maintainable with Raphaël's proposed changes.

Cheers,
--Aurélien

[Message part 2 (text/html, inline)]

Message #41 received at 853224@bugs.debian.org (full text, mbox, reply):

From: Holger Levsen <holger@layer-acht.org>

To: Aurélien COUDERC <zecoucou@free.fr>, 853224@bugs.debian.org, hertzog@debian.org

Subject: re: desktop-base 9.0.3 (was Re: Fwd: Bug#857373: unblock: plasma-workspace/4:5.8.6-2

Date: Tue, 21 Mar 2017 15:47:23 +0000

[Message part 1 (text/plain, inline)]

Hi,

On Mon, Mar 20, 2017 at 10:23:25PM +0100, Aurélien COUDERC wrote:
> I’ve prepared a 9.0.3 and pushed it to mentors. If you get it there,
> take care to use the last one as there were several tries.
> 
> Feel free to diff and review it and push it to unstable as I don’t know
> if / when I’ll get the upload rights.

the changes look good and sensible to me…

> Also as said earlier I’m not sure this changes by itself deserves a
> freeze exception so I’ll leave it up to you.

…however I also agree with this. (I dont think they deserve a freeze
exception on their own….)

I'll still upload this to unstable now, for several reasons:

- the code *is* cleaner and should IMHO be in stretch, so it's good to give it
  more testing, in case the RT wants it in stretch.
- should a serious issue in desktop-base be found, we can always upload 9.0.4
  containing these changes *or* removing them again, in case the RT doesnt want 
  them in stretch.

So to be clear: I don't plan to file an unblock bug for this.

I'll also upload to DELAYED-2 in case one of you thinks I'm crazy and wants to
prevent this upload.


-- 
cheers,
	Holger

[signature.asc (application/pgp-signature, inline)]

Message #46 received at 853224-close@bugs.debian.org (full text, mbox, reply):

From: Aurélien COUDERC <zecoucou@free.fr>

To: 853224-close@bugs.debian.org

Subject: Bug#853224: fixed in desktop-base 9.0.3

Date: Thu, 23 Mar 2017 16:34:24 +0000

Source: desktop-base
Source-Version: 9.0.3

We believe that the bug you reported is fixed in the latest version of
desktop-base, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 853224@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Aurélien COUDERC <zecoucou@free.fr> (supplier of updated desktop-base package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Mon, 30 Jan 2017 22:21:40 +0100
Source: desktop-base
Binary: desktop-base
Architecture: source
Version: 9.0.3
Distribution: unstable
Urgency: medium
Maintainer: Gustavo Franco <stratus@debian.org>
Changed-By: Aurélien COUDERC <zecoucou@free.fr>
Description:
 desktop-base - common files for the Debian Desktop
Closes: 853224
Changes:
 desktop-base (9.0.3) unstable; urgency=medium
 .
   * Fix a few problems in maintainer scripts, thanks Raphaël Hertzog for the
     detailed review.
     No change in behaviour but it will make the scripts more readable and
     maintainable.
     - preinst: reorganize if conditions for package version detection in a
                readable order.
     - prerm: remove references to non existing $priority variable in loops.
     - prerm: no need to remove secondary alternatives just before removing
              a main alternative. Secondary are removed in the process anyway.
     (Closes: #853224)
Checksums-Sha1:
 ac72ed722c1f93add73582d49a65b76e7f5b33f7 1906 desktop-base_9.0.3.dsc
 41589463eb8eabd05a4f99e0a3fbf3e5d157ef52 2178400 desktop-base_9.0.3.tar.xz
 a2bb21a20468ac5042d99870c391b88c75a6fa09 7165 desktop-base_9.0.3_source.buildinfo
Checksums-Sha256:
 669c048d7776eb8d66f57055d68bf0ce04f26b0e1bd557d67308be84069361e3 1906 desktop-base_9.0.3.dsc
 604d4c2dbc39020651a589a5d757dd5c8508cd3edf66aa0f445cce81d8121f84 2178400 desktop-base_9.0.3.tar.xz
 74ab372399a69a267c09f9a0369a9d4e178b38c6a23ad31a5afb370482863c6e 7165 desktop-base_9.0.3_source.buildinfo
Files:
 157ec71a048624927206fac27ee2d4ee 1906 x11 optional desktop-base_9.0.3.dsc
 6525ca224b1f812e1fd4f51c0e82388b 2178400 x11 optional desktop-base_9.0.3.tar.xz
 d248426a56735decc39af48393159a4b 7165 x11 optional desktop-base_9.0.3_source.buildinfo

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIVAwUBWNFOZwkauFYGmqocAQr9uBAAtVhsZ99SpQN7gqJ1Ipkg0x1YNe82ynNv
HuBHUHxQzUPQ24arMUj1jr7PsC6zuZR0VbXnpdGDoEBMhwlLwvI4GSpQogLGreNS
6Pvz1amfb7lzPB+MKD+sq5EiwhJhk7Wy4Zh7B8dlWhQnevi2Y+rxHLN/NhoogRGj
sayGv/hRDyGkfzkhGBm908rWvrh4fPqbsugAOjPEfTBx5O9QcZlN3wFtdqB7A7Zq
JjitrytHvTQNRoWte0msxWfjjrzBUnVlt+EBRJVRoMnAtDzmG4NYLEphaFs5PoOZ
LeWwwOn5Hp2K22Fx9lMD8lpAA4jE8mvpygLIPQRkLN/Z0WnOIUDELlr7DXIDrOrV
s5cX46f3zlbIc5L6dvLsO3bCsv8z46sEQ1qyV5axRRjUafWQrFmRpQk9egstXhjd
UqPktexm0a3HUk4SWyGt6E8efM6P+mAOJs4dOm/Ut/aD5oSQzyDlubPENVV3BLHH
r/5MPrCylBGHK4d/zLg2qxV6pwU+5udtaFJUveYoLrtAVegj7JN4UT9G5cfMRHvs
EYyNNKeSzdRRvzRsCUutvc+F1vf+L1PUpYd0C6D+NddVVivYPWk6CPNYzqDa0cab
GJkpH6Vh4cop7DQn9en4nZY7QMCg9cZPQnYZoH9vDKdjzeKClaB47dAFEqOThwJY
RpvCQaU/SgQ=
=H3z8
-----END PGP SIGNATURE-----

Send a report that this bug log contains spam.